feat(nextjs): Switch to randomized tunnel route as default #1011
Conversation
|
andreiborza
left a comment
andreiborza
left a comment
There was a problem hiding this comment.
As discussed on slack, I'm wondering if we want to actually default the tunnel route option to true. Maybe setting it to true is okay if we mention that they should also switch to an allow list for routes that should be handled by the middleware.
|
I'd first test this option within our own apps before making it the default within the wizard 👍 |
Lms24
left a comment
Lms24
left a comment
There was a problem hiding this comment.
This PR doesn't actually change the default value of the wizard, right? It just changes that if users opt into tunneling, they get the randomized route.
Just asking because we shouldn't default to tunneling due to it potentially heavily increasing traffic on Vercel and therefore cost for users. IIRC the wizard mentions this when it asks users if they want tunneling.
|
The risk of breaking apps that use turbopack is too high here as we cannot automatically add matchers for random routes in turbopack. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1011 +/- ##
==========================================
- Coverage 27.98% 0 -27.99%
==========================================
Files 130 0 -130
Lines 14233 0 -14233
Branches 882 0 -882
==========================================
- Hits 3983 0 -3983
+ Misses 10233 0 -10233
+ Partials 17 0 -17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ref getsentry/sentry-javascript#16626